Re-Add Solidus/TaxCategoryDeprecated cop #55
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add some cops that were removed earlier due to false positives by adding a warning severity on the offense instead.
Re-Add Solidus/TaxCategoryDeprecated cop
This cop was removed earlier as it was giving a lot of false positives.
We have re-added this cop again but now with a warning offense so that it doesn't raise any errors for this cop but warns the user to have a look at certain places in the code where something might be wrong.
Severity:
Wrong Code
Correct Code
Solidus PR Link: # Replace with link to Solidus PR where the change has been made.
Before submitting the PR make sure the following are checked:
master
(if not - rebase it)./config/default.yml
Issue #53