Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Add Solidus/TaxCategoryDeprecated cop #55

Closed
wants to merge 1 commit into from

Conversation

piyushswain
Copy link
Contributor

@piyushswain piyushswain commented Aug 21, 2023

This PR aims to add some cops that were removed earlier due to false positives by adding a warning severity on the offense instead.

Re-Add Solidus/TaxCategoryDeprecated cop

This cop was removed earlier as it was giving a lot of false positives.

We have re-added this cop again but now with a warning offense so that it doesn't raise any errors for this cop but warns the user to have a look at certain places in the code where something might be wrong.


Severity:

  • - info
  • - refactor
  • - convention (default)
  • - warning
  • - error
  • - fatal

Wrong Code

model.tax_category = data

Correct Code

model.tax_categories = [data]

Solidus PR Link: # Replace with link to Solidus PR where the change has been made.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one cop with a clear title and description.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran and ensured all tests are passing on a development environment.
  • If this is a new cop, added an entry for the cop on /config/default.yml
  • Updated Changelog

Issue #53

@piyushswain piyushswain self-assigned this Aug 21, 2023
This cop was removed earlier as it was giving a lot of false positives.

We have re-added this cop again but now with a warning offense so that it doesn't raise any errors for this cop
but warns the user to have a look at certain places in the code where something might be wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant